Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-99113: Make Sure the GIL is Acquired at the Right Places #104208

Merged
merged 7 commits into from
May 6, 2023
Merged

gh-99113: Make Sure the GIL is Acquired at the Right Places #104208

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ca1f78e
Add _PyEval_AcquireLock().
ericsnowcurrently Apr 10, 2023
c5d3b2c
Add _PyThreadState_SwapNoGIL().
ericsnowcurrently Apr 10, 2023
2404310
Acquire the GIL when not owned.
ericsnowcurrently Apr 10, 2023
85702ae
Fix a typo.
ericsnowcurrently May 6, 2023
3cc9dc3
Do not release the GIL when not necessary.
ericsnowcurrently May 6, 2023
3104796
Make sure the GIL is held by the current thread in _PyEval_InitGIL().
ericsnowcurrently May 6, 2023
56064c7
Release the GIL after swapping thread states.
ericsnowcurrently May 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix a typo.
  • Loading branch information
@ericsnowcurrently
ericsnowcurrently committed May 6, 2023
commit 85702ae366068db7923dca2190f665e970f6ab60
2 changes: 1 addition & 1 deletion Python/ceval_gil.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -541,7 +541,7 @@ _PyEval_InitGIL(PyThreadState *tstate, int own_gil)
}
else {
PyThread_init_thread();
// XXX per-interpreter GIL: switch to interp->ceval._gil.
// XXX per-interpreter GIL: switch to interp->_gil.
init_own_gil(tstate->interp, &tstate->interp->runtime->ceval.gil);
locked = 0;
}
Expand Down