Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-103092: Isolate msvcrt #103248

Merged
merged 9 commits into from
Apr 12, 2023
Merged

gh-103092: Isolate msvcrt #103248

merged 9 commits into from
Apr 12, 2023

Conversation

aisk
Copy link
Contributor

@aisk aisk commented Apr 4, 2023 •
edited by bedevere-bot
Loading

@aisk aisk requested a review from a team as a code owner April 4, 2023 16:07
@bedevere-bot bedevere-bot mentioned this pull request Apr 4, 2023
Open
25 tasks
arhadthedev
arhadthedev reviewed Apr 5, 2023
View reviewed changes
PC/msvcrtmodule.c Outdated Show resolved Hide resolved
@aisk @arhadthedev
Update PC/msvcrtmodule.c
bc8aa95 
Co-authored-by: Oleg Iarygin <dralife@yandex.ru>
@erlend-aasland erlend-aasland self-requested a review April 8, 2023 19:48
erlend-aasland
erlend-aasland reviewed Apr 8, 2023
View reviewed changes
Misc/NEWS.d/next/Library/2023-04-04-21-44-25.gh-issue-103092.Dz0_Xn.rst Outdated Show resolved Hide resolved
PC/msvcrtmodule.c Outdated Show resolved Hide resolved
PC/msvcrtmodule.c Outdated Show resolved Hide resolved
@erlend-aasland
Copy link
Contributor

erlend-aasland commented Apr 8, 2023 •
edited
Loading

I'd like to land these first:

@erlend-aasland erlend-aasland changed the title gh-103092: isolate msvcrt gh-103092: Isolate msvcrt Apr 8, 2023
aisk and others added 5 commits April 9, 2023 13:05
@aisk @erlend-aasland
Update Misc/NEWS.d/next/Library/2023-04-04-21-44-25.gh-issue-103092.D…
8dd469f 
…z0_Xn.rst

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@aisk @erlend-aasland
Update PC/msvcrtmodule.c
cdc37b7 
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@aisk @erlend-aasland
Update PC/msvcrtmodule.c
6119c5b 
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@aisk
fix error branch in exec_module
b3f5edb
@erlend-aasland
Merge branch 'main' into isolate-msvcrt
cb96632
@erlend-aasland

This comment was marked as outdated.

Sign in to view
@erlend-aasland erlend-aasland merged commit dce2d38 into python:main Apr 12, 2023
@erlend-aasland
Copy link
Contributor

Thanks, @aisk.

@aisk aisk deleted the isolate-msvcrt branch April 12, 2023 11:54
aisk added a commit to aisk/cpython that referenced this pull request Apr 18, 2023
@aisk
pythongh-103092: Isolate msvcrt (python#103248)
21ceaf5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arhadthedev arhadthedev arhadthedev left review comments

@erlend-aasland erlend-aasland erlend-aasland approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aisk @erlend-aasland @arhadthedev @bedevere-bot