Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-101283: Fix the versionchanged of gh-101283 (3.12 only) #101728

Merged
merged 1 commit into from
Feb 9, 2023
Merged

gh-101283: Fix the versionchanged of gh-101283 (3.12 only) #101728

merged 1 commit into from
Feb 9, 2023

Conversation

arhadthedev
Copy link
Member

@arhadthedev arhadthedev commented Feb 9, 2023 •
edited by bedevere-bot
Loading

Addresses #101286 (comment):

This version number is wrong. 3.11.2 was released before this change was merged. As this PR is in the main branch, listing it as 3.12 in these docs is more appropriate. Documentation readers should not be expected to know which patch release versions came before a major release.

cc @gpshead @zooba @eryksun

@arhadthedev arhadthedev added the docs Documentation in the Doc dir label Feb 9, 2023
@bedevere-bot bedevere-bot mentioned this pull request Feb 9, 2023
Closed
@arhadthedev arhadthedev mentioned this pull request Feb 9, 2023
Merged
@arhadthedev
Copy link
Member Author

Fully merged, and all the fixes should be in (I hope). Thanks all!

@zooba

@zooba zooba merged commit 6d92373 into python:main Feb 9, 2023
@arhadthedev arhadthedev deleted the gh101283-fix-versionchanged branch February 9, 2023 17:41
carljm added a commit to carljm/cpython that referenced this pull request Feb 10, 2023
@carljm
Merge branch 'main' into inlinecomp2
add772e 
* main:
  Fix some typos in asdl_c.py (pythonGH-101757)
  pythongh-101747: Fix refleak in new `OrderedDict` repr (pythonGH-101748)
  pythongh-101430: Update tracemalloc to handle presize properly. (pythongh-101745)
  pythonGH-101228: Fix typo in docstring for read method of `_io.TextIOWrapper` class (python#101227)
  Fix typo in `test_fstring.py` (python#101600)
  pythongh-101726: Update the OpenSSL version to 1.1.1t (pythonGH-101727)
  pythongh-101283: Fix 'versionchanged' for the shell=True fallback on Windows in 3.12 (pythonGH-101728)
  LibFFI build requires x64 Cygwin, and skip the ARM build (pythonGH-101743)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpshead gpshead gpshead approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arhadthedev @gpshead @zooba @bedevere-bot