GH-100884: email/_header_value_parser: don't encode list separators #100885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There already is already a predefined object with the correct properties, use it.
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
|
All commit authors signed the Contributor License Agreement. |
…tors ListSeparator should not be encoded. This could happen when a long line pushes its separator to the next line, which would have been encoded. Fixes python#100884
serhiy-storchaka
added
needs backport to 3.11
|
Thanks @t-8ch for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 17, 2024
…tors (pythonGH-100885) ListSeparator should not be encoded. This could happen when a long line pushes its separator to the next line, which would have been encoded. (cherry picked from commit 09fab93) Co-authored-by: Thomas Weißschuh <thomas@t-8ch.de>
|
GH-115592 is a backport of this pull request to the 3.12 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 17, 2024
…tors (pythonGH-100885) ListSeparator should not be encoded. This could happen when a long line pushes its separator to the next line, which would have been encoded. (cherry picked from commit 09fab93) Co-authored-by: Thomas Weißschuh <thomas@t-8ch.de>
|
GH-115593 is a backport of this pull request to the 3.11 branch. |
woodruffw
pushed a commit
to woodruffw-forks/cpython
that referenced
this pull request
Mar 4, 2024
…tors (pythonGH-100885) ListSeparator should not be encoded. This could happen when a long line pushes its separator to the next line, which would have been encoded.
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
…tors (pythonGH-100885) ListSeparator should not be encoded. This could happen when a long line pushes its separator to the next line, which would have been encoded.
|
@t-8ch @serhiy-storchaka can you take a look at #118643? Seems that this commit may have introduced a regression |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ListSeparator should not be encoded. This could happen when a long line
pushes its separator to the next line, which would have been encoded.
Fixes #100884