Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy TODOs from code. #119219

Closed
jeremyhylton opened this issue May 20, 2024 · 4 comments
Closed

Remove legacy TODOs from code. #119219

jeremyhylton opened this issue May 20, 2024 · 4 comments
Assignees
Labels
easy type-bug An unexpected behavior, bug, or error

Comments

@jeremyhylton
Copy link
Contributor

jeremyhylton commented May 20, 2024

Bug report

Bug description:

I left a few TODOs in the compiler code from its early development. They are no longer relevant. For example, they comment on issues to consider that do not appear to have been a priority in years.

CPython versions tested on:

CPython main branch

Operating systems tested on:

No response

Linked PRs

@jeremyhylton jeremyhylton added type-bug An unexpected behavior, bug, or error easy labels May 20, 2024
@jeremyhylton jeremyhylton self-assigned this May 20, 2024
jeremyhylton added a commit that referenced this issue May 20, 2024
@rhettinger
Copy link
Contributor

rhettinger commented May 20, 2024

Out of curiosity, were those open items resolved or are they things we just don't care about anymore?

@jeremyhylton
Copy link
Contributor Author

jeremyhylton commented May 20, 2024 via email

@rhettinger
Copy link
Contributor

rhettinger commented May 20, 2024

I didn't have any objections. I was just curious. Please go ahead and do whatever makes sense to you. And thanks for all the work you've done in this arena ;-)

@rubyFeedback
Copy link

Do you see a reason to think harder about it?

Perhaps nostalgia. We may all have higher ambitions when we were younger ... :)

(TODO entries are always a bit awkward though. Some TODOs I can solve quickly or
within a reasonable time; others stay there for years, so perhaps this applies to
the latter one as well, in which case it may be easier to just get rid of them rather
than let them linger.)

estyxx pushed a commit to estyxx/cpython that referenced this issue Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

No branches or pull requests

4 participants