Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Too many tier 2 micro-ops are marked as escaping #116596

Closed
markshannon opened this issue Mar 11, 2024 · 2 comments
Closed

Too many tier 2 micro-ops are marked as escaping #116596

markshannon opened this issue Mar 11, 2024 · 2 comments
Labels
performance Performance or resource usage type-bug An unexpected behavior, bug, or error

Comments

@markshannon
Copy link
Member

markshannon commented Mar 11, 2024 •
edited by bedevere-app bot
Loading

Bug report

Bug description:

There are too many _SET_IP and _CHECK_VALIDITY micro-ops being inserted into tier 2 code.

There are two causes of this:

  1. Too many micro-ops are marked as escaping
  2. Python call uops do not technically escape but must be preceded by _SET_IP in order to correctly set the return address. We need a way of marking these, so that we insert _SET_IP before them, but do not needlessly insert _CHECK_VALIDITY after them.

CPython versions tested on:

3.13, CPython main branch

Operating systems tested on:

No response

Linked PRs
@markshannon markshannon added type-bug An unexpected behavior, bug, or error performance Performance or resource usage labels Mar 11, 2024
@bedevere-app bedevere-app bot mentioned this issue Mar 11, 2024
Merged
markshannon added a commit that referenced this issue Mar 11, 2024
@markshannon
GH-116596: Better determination of escaping uops. (GH-116597)
b6ae6da
@hugovk
Copy link
Member

hugovk commented Mar 15, 2024

Triage: can this issue be closed?

adorilson pushed a commit to adorilson/cpython that referenced this issue Mar 25, 2024
@markshannon @adorilson
pythonGH-116596: Better determination of escaping uops. (pythonGH-116597
a0ec499 
)
@markshannon
Copy link
Member Author

Yes

diegorusso pushed a commit to diegorusso/cpython that referenced this issue Apr 17, 2024
@markshannon @diegorusso
pythonGH-116596: Better determination of escaping uops. (pythonGH-116597
5df00b4 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
performance Performance or resource usage type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hugovk @markshannon