Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combine SAVE_IP and SAVE_CURRENT_IP into a new uop #109214

Closed
gvanrossum opened this issue Sep 10, 2023 · 1 comment
Closed

Combine SAVE_IP and SAVE_CURRENT_IP into a new uop #109214

gvanrossum opened this issue Sep 10, 2023 · 1 comment

Comments

@gvanrossum
Copy link
Member

gvanrossum commented Sep 10, 2023 •
edited by bedevere-app bot
Loading

See faster-cpython/ideas#621 (comment):

Now, there's an explicit SAVE_CURRENT_IP in some macros (before every _POP_FRAME and _PUSH_FRAME). That's because it also acts as a flag for the code generator, which, combined with the preceding SAVE_IP, makes it effectively save a pointer to the next instruction (which is what's needed by the frame push/pop uops). But there's so much special-casing here that we might as well either introduce a new uop for the combined special effects or special-case _POP_FRAME and _PUSH_FRAME.

Also rename SAVE_IP to SET_IP (from the same issue). [DONE]

Linked PRs
This was referenced Sep 10, 2023
Closed
Open
Merged
gvanrossum added a commit that referenced this issue Sep 11, 2023
@gvanrossum
gh-109214: Rename SAVE_IP to _SET_IP, and similar (#109285)
fbaf77e 
* Rename SAVE_IP to _SET_IP
* Rename EXIT_TRACE to _EXIT_TRACE
* Rename SAVE_CURRENT_IP to _SAVE_CURRENT_IP
* Rename INSERT to _INSERT (This is for Ken Jin's abstract interpreter)
* Rename IS_NONE to _IS_NONE
* Rename JUMP_TO_TOP to _JUMP_TO_TOP
vstinner pushed a commit to vstinner/cpython that referenced this issue Sep 13, 2023
@gvanrossum @vstinner
pythongh-109214: Rename SAVE_IP to _SET_IP, and similar (python#109285)
bc9323c 
* Rename SAVE_IP to _SET_IP
* Rename EXIT_TRACE to _EXIT_TRACE
* Rename SAVE_CURRENT_IP to _SAVE_CURRENT_IP
* Rename INSERT to _INSERT (This is for Ken Jin's abstract interpreter)
* Rename IS_NONE to _IS_NONE
* Rename JUMP_TO_TOP to _JUMP_TO_TOP
@bedevere-app bedevere-app bot mentioned this issue Oct 12, 2023
Merged
markshannon added a commit that referenced this issue Oct 12, 2023
@markshannon
GH-109214: Convert _SAVE_CURRENT_IP to _SET_IP in tier 2 trace creati…
19b7ead 
…on. (GH-110755)
vstinner pushed a commit to vstinner/cpython that referenced this issue Oct 12, 2023
@markshannon @vstinner
pythonGH-109214: Convert _SAVE_CURRENT_IP to _SET_IP in tier 2 trace …
8471b20 
…creation. (pythonGH-110755)
@bedevere-app bedevere-app bot mentioned this issue Oct 17, 2023
Merged
brandtbucher added a commit that referenced this issue Oct 24, 2023
@brandtbucher
GH-109214: _SET_IP before _PUSH_FRAME (but not _POP_FRAME) (GH-111001)
e5168ff
@gvanrossum
Copy link
Member Author

Looks like this is either done or no longer desirable. Note that SAVE_IP is now _SET_IP and SAVE_CURRENT_IP is now _SAVE_RETURN_OFFSET. The latter is only present before _PUSH_FRAME, not _POP_FRAME.

aisk pushed a commit to aisk/cpython that referenced this issue Feb 11, 2024
@brandtbucher @aisk
pythonGH-109214: _SET_IP before _PUSH_FRAME (but not _POP_FRAME) (pyt…
422f55e 
…honGH-111001)
Glyphack pushed a commit to Glyphack/cpython that referenced this issue Sep 2, 2024
@markshannon @Glyphack
pythonGH-109214: Convert _SAVE_CURRENT_IP to _SET_IP in tier 2 trace …
1da6029 
…creation. (pythonGH-110755)
Glyphack pushed a commit to Glyphack/cpython that referenced this issue Sep 2, 2024
@brandtbucher @Glyphack
pythonGH-109214: _SET_IP before _PUSH_FRAME (but not _POP_FRAME) (pyt…
d602540 
…honGH-111001)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gvanrossum