Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asyncio.base_events.Server is not exposed as Asyncio.Server in early versions of 3.9 and 3.10 and all previous versions #106882

Closed
jack60612 opened this issue Jul 19, 2023 · 8 comments
Labels
docs Documentation in the Doc dir topic-asyncio

Comments

@jack60612
Copy link
Contributor

jack60612 commented Jul 19, 2023

Documentation:

The documentation for python shows asyncio.base_events.Server as asyncio.Server in all python versions, Offending Page. However, it is not exposed as such until late versions of 3.9, 3.10 and 3.11.0.

Relevant Facts:

PR #31760 makes the change exposing it as asyncio.Server, but this only effects newer versions.

My Comments:

I can make a pr adding a note to the docs, let me know what you would like me to do.

Linked PRs

@jack60612 jack60612 added the docs Documentation in the Doc dir label Jul 19, 2023
@AlexWaygood
Copy link
Member

Thanks for the report. However, Python 3.10 and lower now only accept security-related fixes. The error in the docs here only affects Python 3.10 and lower, and the bug doesn't relate to a security issue, so I'm afraid we won't be fixing this at this point.

@AlexWaygood AlexWaygood closed this as not planned Won't fix, can't repro, duplicate, stale Jul 19, 2023
@jack60612
Copy link
Contributor Author

Thanks for the report. However, Python 3.10 and lower now only accept security-related fixes. The error in the docs here only affects Python 3.10 and lower, and the bug doesn't relate to a security issue, so I'm afraid we won't be fixing this at this point.

Ok, Thanks.

@jack60612
Copy link
Contributor Author

Oh wait, the history in 3.11 still needs to be corrected though, or do you disagree? @AlexWaygood

@AlexWaygood
Copy link
Member

Yes, I suppose you could add a .. versionchanged sentence noting that it's only available as asyncio.Server on 3.9.11+, 3.10.3+, and 3.11+. Feel free to make a PR :)

@AlexWaygood AlexWaygood reopened this Jul 19, 2023
@jack60612
Copy link
Contributor Author

Yes, I suppose you could add a .. versionchanged sentence noting that it's only available as asyncio.Server on 3.9.11+, 3.10.3+, and 3.11+. Feel free to make a PR :)

Sounds good, thanks again.

@altendky
Copy link
Contributor

I would note that the inline history is still incorrect in the 3.11 docs by omitting the addition of this availability. Though sure, I don't expect that to reopen this issue.

@AlexWaygood
Copy link
Member

I would note that the inline history is still incorrect in the 3.11 docs by omitting the addition of this availability. Though sure, I don't expect that to reopen this issue.

That's already been noted above, and I've already reopened the issue as a result, and @jack60612 has already submitted a PR to rectify that, which will be backported to the 3.12 and 3.11 docs

AlexWaygood pushed a commit that referenced this issue Jul 19, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jul 19, 2023
…on 3.11+ (pythonGH-106901)

And later versions of 3.10, 3.9
(cherry picked from commit 1e1f4e9)

Co-authored-by: Jack Nelson <jack@jacknelson.xyz>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jul 19, 2023
…on 3.11+ (pythonGH-106901)

And later versions of 3.10, 3.9
(cherry picked from commit 1e1f4e9)

Co-authored-by: Jack Nelson <jack@jacknelson.xyz>
AlexWaygood pushed a commit that referenced this issue Jul 19, 2023
… on 3.11+ (GH-106901) (#106903)

gh-106882: Note that `asyncio.Server` is only publicly exposed on 3.11+ (GH-106901)

And later versions of 3.10, 3.9
(cherry picked from commit 1e1f4e9)

Co-authored-by: Jack Nelson <jack@jacknelson.xyz>
AlexWaygood pushed a commit that referenced this issue Jul 19, 2023
… on 3.11+ (GH-106901) (#106902)

gh-106882: Note that `asyncio.Server` is only publicly exposed on 3.11+ (GH-106901)

And later versions of 3.10, 3.9
(cherry picked from commit 1e1f4e9)

Co-authored-by: Jack Nelson <jack@jacknelson.xyz>
@AlexWaygood
Copy link
Member

Thanks again @jack60612!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir topic-asyncio
Projects
Status: Done
Development

No branches or pull requests

4 participants