Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated Py_TRASHCAN_SAFE_BEGIN/ Py_TRASHCAN_SAFE_END #105111

Closed
iritkatriel opened this issue May 30, 2023 · 0 comments · Fixed by #105112
Closed

Remove deprecated Py_TRASHCAN_SAFE_BEGIN/ Py_TRASHCAN_SAFE_END #105111

iritkatriel opened this issue May 30, 2023 · 0 comments · Fixed by #105112
Labels
3.13 bugs and security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) type-feature A feature request or enhancement

Comments

@iritkatriel
Copy link
Member

iritkatriel commented May 30, 2023 •
edited by bedevere-bot
Loading

Py_TRASHCAN_SAFE_BEGIN/ Py_TRASHCAN_SAFE_END were deprecated in 3.11, to be replaced by Py_TRASHCAN_BEGIN/Py_TRASHCAN_END which were added in 3.8. The deprecated macros are flawed (can lead to a crash) so we should not delay their removal.

For more history, see https://mail.python.org/archives/list/python-dev@python.org/message/KWFX6XX3HMZBQ2BYBVL7G74AIOPWO66Y/.

Linked PRs
@iritkatriel iritkatriel added type-feature A feature request or enhancement interpreter-core (Objects, Python, Grammar, and Parser dirs) 3.13 bugs and security fixes labels May 30, 2023
iritkatriel added a commit to iritkatriel/cpython that referenced this issue May 30, 2023
@iritkatriel
pythongh-105111: remove deprecated macros Py_TRASHCAN_SAFE_BEGIN and …
3f974b3 
…Py_TRASHCAN_SAFE_END
@iritkatriel iritkatriel mentioned this issue May 30, 2023
Merged
iritkatriel added a commit that referenced this issue May 31, 2023
@iritkatriel
gh-105111: remove deprecated macros Py_TRASHCAN_SAFE_BEGIN and Py_TRA…
fbc9d0d 
…SHCAN_SAFE_END (#105112)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.13 bugs and security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
1 participant
@iritkatriel