apply petr's comment

python · Aug 7, 2021 · 4cfebb2 · 4cfebb2
1 parent a940aaf
commit 4cfebb2
Showing 1 changed file with 9 additions and 2 deletions.
diff --git a/Modules/_testcapimodule.c b/Modules/_testcapimodule.c
@@ -1174,19 +1174,26 @@ test_get_type_qualname(PyObject *self, PyObject *Py_UNUSED(ignored))
     if (HeapTypeNameType == NULL) {
         Py_RETURN_NONE;
     }
+    tp_qualname = PyType_GetQualName((PyTypeObject *)HeapTypeNameType);
+    assert(strcmp(PyUnicode_AsUTF8(tp_qualname), "HeapTypeNameType") == 0);
+    Py_DECREF(tp_qualname);
+
     PyObject *spec_name = PyUnicode_FromString(HeapTypeNameType_Spec.name);
+    if (spec_name == NULL) {
+        goto done;
+    }
     if (PyObject_SetAttrString(HeapTypeNameType,
                                "__qualname__", spec_name) < 0) {
         Py_DECREF(spec_name);
-        Py_DECREF(HeapTypeNameType);
-        Py_RETURN_NONE;
+        goto done;
     }
     tp_qualname = PyType_GetQualName((PyTypeObject *)HeapTypeNameType);
     assert(strcmp(PyUnicode_AsUTF8(tp_qualname),
                   "_testcapi.HeapTypeNameType") == 0);
     Py_DECREF(spec_name);
     Py_DECREF(tp_qualname);
 
+  done:
     Py_DECREF(HeapTypeNameType);
     Py_RETURN_NONE;
 }