Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend KazooRetry to support time deadlines #102

Closed
wants to merge 4 commits into from
Closed

Extend KazooRetry to support time deadlines #102

wants to merge 4 commits into from

Conversation

novas0x2a
Copy link
Contributor

No description provided.

@novas0x2a
Copy link
Contributor Author

Note that this depends on #101
It addresses #89 in much the same way #92 does, plus also #62.

@novas0x2a
Make client take a retry object rather than params for one
1fbbefa
@novas0x2a
warn about old-style retry params for eventual removal
6775406
@novas0x2a
Merge retry sleeper functionality into retry class
504480f 
Having the sleeper be separate complicates the retry API and makes it
difficult to implement more complex retry behavior.

This has a user-visible change in that, previously, all hosts in the
host list would be tried before an increment happened- in this version,
each connection failure results in an increment; it's worth noting
because users might want to increase the number of retries.

I changed it both for the commit after this one and also because if you
have a shortish session timeout, and the machine you're on loses network
connectivity but has a large server list, it will end up slamming the
machine as it tries all of the servers without backing off.
@novas0x2a
Add time deadline functionality to KazooRetry
2c3e3f1 
This allows you to say, for example, "retry this for 10 seconds"
bbangert added a commit that referenced this pull request Jul 17, 2013
@bbangert
- Issue #62, #92, #89, #101, #102: Allow KazooRetry to have a
3d577e4 
  max deadline, transition properly when connection fails to LOST, and
  setup separate connection retry behavior from client command retry
  behavior. Patches by Mike Lundy.
@bbangert bbangert closed this Jul 17, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@novas0x2a @bbangert