Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(overlay): allow full customization of the error overlay integration #44

Merged
merged 7 commits into from
Mar 27, 2020
Merged

feat(overlay): allow full customization of the error overlay integration #44

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
002a514
refactor: extract types into common file
pmmmwh Mar 1, 2020
c27403f
refactor: update type references within the project
pmmmwh Mar 1, 2020
a0de3b5
feat: add options validator
pmmmwh Mar 1, 2020
3f0e2c5
feat(overlay): only inject overlay entry when user uses the integration
pmmmwh Mar 1, 2020
dc4c660
feat(overlay): fix typos in options validator to correctly inject def…
pmmmwh Mar 1, 2020
3ceeae2
feat(overlay): hook up runtime utils to use customized error overlay
pmmmwh Mar 1, 2020
c42cd5b
docs(overlay): refactor docs and document overlay options usage
pmmmwh Mar 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat(overlay): fix typos in options validator to correctly inject def… 
…aults
  • Loading branch information
@pmmmwh
pmmmwh committed Mar 2, 2020
commit dc4c6609ff06ae3733ce76f83156840cf3f99ae9
7 changes: 5 additions & 2 deletions src/helpers/validateOptions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ const defaultOptions = {
/** @type {import('../types').ErrorOverlayOptions} */
const defaultOverlayOptions = {
entry: require.resolve('../runtime/ErrorOverlayEntry'),
overlay: require.resolve('../overlay'),
module: require.resolve('../overlay'),
};

/**
Expand All @@ -19,7 +19,10 @@ const defaultOverlayOptions = {
module.exports = function validateOptions(options) {
const validatedOptions = Object.assign(defaultOptions, options);

if (typeof validatedOptions.overlay !== 'boolean') {
if (
typeof validatedOptions.overlay !== 'undefined' &&
typeof validatedOptions.overlay !== 'boolean'
) {
if (typeof validatedOptions.overlay.module !== 'string') {
throw new Error(
`To use the "overlay" option, a string must be provided in the "module" property. Instead, the provided value has type: "${typeof options
Expand Down