Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom EventSource and web socket url #51

Closed
matheus1lva opened this issue Mar 24, 2020 · 2 comments · Fixed by #64
Closed

Add custom EventSource and web socket url #51

matheus1lva opened this issue Mar 24, 2020 · 2 comments · Fixed by #64
Labels
enhancement New feature or request

Comments

@matheus1lva
Copy link

matheus1lva commented Mar 24, 2020

I'm currently one of the maintainers on webpack-plugin-serve and we also want to support it (specially for one my use cases).

But due to how tangled to wds and wdm this plugin is, we would need support for custom message handlers (similar to https://github.com/pmmmwh/react-refresh-webpack-plugin/blob/master/src/runtime/WHMEventSource.js) and a custom websocket properties!

Would these things be supported? Technically i don't want to embbed a custom message handler to this as well, i would like to leave it as generic as it would be so we can add more extensiability!

something like:

new ReactRefreshWebpackPlugin({
   ws: {
     url: localhost,
     port: 12345
   },
   messageHandler: () => {
     ....
   }
})

what do you guys think?

Edit: so we already have one PR on going, which would help 1/2 of this issue: #44

@pmmmwh
Copy link
Owner

pmmmwh commented Mar 29, 2020

Hi! I am working on an API to make this less painful. It will probably take me a few more days, but once that's ready I'll release a beta to gather feedback.

@pmmmwh pmmmwh added the enhancement New feature or request label Mar 29, 2020
@matheus1lva
Copy link
Author

Oh ok! Let me know please and thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants