Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove e2e related code and libs #8

Closed
wants to merge 4 commits into from
Closed

chore: Remove e2e related code and libs #8

wants to merge 4 commits into from

Conversation

giscafer
Copy link
Collaborator

close #4

@LiuuY
Copy link
Collaborator

LiuuY commented Mar 30, 2020

angular.json, package.json 里面的相关的命令没有删；
karma 也要删除。

@LiuuY LiuuY self-requested a review March 30, 2020 14:20
@LiuuY
Copy link
Collaborator

LiuuY commented Mar 30, 2020

不应该删除 jasmine 相关的内容，后续单元测试会用到。
这个 issue 想解决的就是，本项目不打算写 e2e 测试，所以要删除相关内容，且删干净。

@giscafer giscafer closed this Mar 30, 2020
@giscafer
Copy link
Collaborator Author

我的理解问题，以为 karma 和jasmine 搭配使用多删了。

@phodal
Copy link
Owner

phodal commented Mar 31, 2020

可以再试试 😄😄😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LiuuY LiuuY Awaiting requested review from LiuuY

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove e2e related code and libs
3 participants
@giscafer @LiuuY @phodal