Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc bugs + please pyflakes #89

Merged
merged 12 commits into from
Mar 31, 2024
Merged

misc bugs + please pyflakes #89

merged 12 commits into from
Mar 31, 2024

Conversation

a-detiste
Copy link
Contributor

I use pyflakes to verify I'm not introducing regressions.

Here's a real bug I have no idea how to fix:

./paste/debug/watchthreads.py:279:16: undefined name 'environ_template'
./paste/debug/watchthreads.py:290:17: undefined name 'environ_template'
./paste/debug/watchthreads.py:295:17: undefined name 'environ_template'

@cdent
Copy link
Collaborator

cdent commented Mar 27, 2024

What the state of this?

Still issues with undefined name 'environ_template'? Or did that get resolved?

@a-detiste
Copy link
Contributor Author

`undefined name 'environ_template``: this has always been broken since the first/only commit and I have no idead what author tried to do. I fixed the other bugs I could.

@cdent cdent merged commit 7654dd8 into pasteorg:master Mar 31, 2024
6 checks passed
@cdent
Copy link
Collaborator

cdent commented Mar 31, 2024

Will look into the environ_template thing and and do a new release soon.

Thanks again for your ongoing assistance. Very much appreciated.

@a-detiste
Copy link
Contributor Author

The previous Debian maintainer left so I adopted this one package.
We have automated test triggered on all reverse-dependencies on upgrade.
I'll ping you if things needs more fixing.

@cdent
Copy link
Collaborator

cdent commented Mar 31, 2024

Looks like the format_environ that contains environ_template is dead code not used by the surrounding WSGI app.

I would guess it became stale some time before I adopted paste.

I'll do some more thorough searching and remove it becomes clear nothing is using it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants