Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opt: refine the code of I/O handlers #586

Merged
merged 3 commits into from
Apr 21, 2024
Merged

opt: refine the code of I/O handlers #586

merged 3 commits into from
Apr 21, 2024

Conversation

panjf2000
Copy link
Owner

No description provided.

@github-actions github-actions bot added the enhancement New feature or request label Apr 21, 2024
Copy link

codecov bot commented Apr 21, 2024

Codecov Report

Attention: Patch coverage is 76.66667% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 78.83%. Comparing base (d473f26) to head (aee4817).

Files Patch % Lines
acceptor_unix.go 50.00% 6 Missing ⚠️
engine_unix.go 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #586      +/-   ##
==========================================
- Coverage   78.96%   78.83%   -0.13%     
==========================================
  Files          25       23       -2     
  Lines        2258     2249       -9     
==========================================
- Hits         1783     1773      -10     
- Misses        327      329       +2     
+ Partials      148      147       -1     
Flag Coverage Δ
unittests 78.83% <76.66%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@panjf2000 panjf2000 added the optimization Some small optimizations label Apr 21, 2024
@panjf2000 panjf2000 merged commit 39c175b into dev Apr 21, 2024
31 of 33 checks passed
@panjf2000 panjf2000 deleted the code-opt branch April 21, 2024 14:52
leslie-fei pushed a commit to leslie-fei/gnet that referenced this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request optimization Some small optimizations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant