Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full hub compatibility #144

Closed
8 tasks done
owenthereal opened this issue Dec 29, 2013 · 8 comments
Closed
8 tasks done

Full hub compatibility #144

owenthereal opened this issue Dec 29, 2013 · 8 comments
Assignees
Labels

Comments

@owenthereal
Copy link
Owner

We're not 100% compatible with hub yet. Let's make it happen! There're some tests flagged as "@wip". We need to minimize those.

  • authentication
  • browse
  • clone
  • create
  • fork
  • pull request
  • remote add
  • submodule add
@calavera
Copy link
Contributor

It turns out that submodule add was already completely working as expected, so I just removed the wip mark 😄

@owenthereal
Copy link
Owner Author

@calavera 🆒

@calavera
Copy link
Contributor

Oh, weird, it fails on travis, I'm going to double check it.

@owenthereal
Copy link
Owner Author

I just checked. It passed locally for me too. Maybe that's why I disabled it at the first place.

@calavera
Copy link
Contributor

@jingweno so, the remaining issues are related to the fact that we don't use ssh by default on clones. As we already discussed in #117 I don't think that it should be the default option, so I'm going to leave it up to you, I'll be fine either way.

@owenthereal
Copy link
Owner Author

@calavera I'm happy with what it is now. Flagging it done

@calavera
Copy link
Contributor

calavera commented Jan 1, 2014

@jingweno the remote add remaining issue is also the same as the clone issue 😄

@owenthereal
Copy link
Owner Author

Just in time for 2014! Flagged it done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants