Skip to content
This repository has been archived by the owner on May 17, 2021. It is now read-only.

Fix for Freebox in bridge mode (issue 2789) #2796

Merged
merged 1 commit into from
Jul 6, 2015
Merged

Fix for Freebox in bridge mode (issue 2789) #2796

merged 1 commit into from
Jul 6, 2015

Conversation

lolodomo
Copy link
Contributor

Please find a fix for the issue #2789.

@teichsta teichsta added the bug label Jun 29, 2015
@teichsta teichsta added this to the 1.7.1 milestone Jun 29, 2015
@teichsta
Copy link
Member

Thanks for this fix @lolodomo. Are there any users that can confirm your fix is working?

@lolodomo
Copy link
Contributor Author

There was exchanges with Mickael on the "forum", the guy who discovered the problem. I provided an intermediate version to clearly identify where was the problem and this version already fixed his problem.
This PR is not exactly this intermediate version but I am confident (100%) that this PR fix the issue.

@teichsta
Copy link
Member

Thanks for the update, @lolodomo!

There was exchanges with Mickael on the "forum", the guy who discovered the problem.
ok, could you please add the link to this discussion here?

Since this fix is quite huge i tend to not cherry-pick it into 1.7. What do you think?

@lolodomo
Copy link
Contributor Author

Thomas, here is the link to the discussion: https://groups.google.com/d/msg/openhab/mJSFoTPZyz8/uWp1IyC6uWgJ

The change is in fact not huge at all even if the diff looks big. What I have changed is mainly cutting a big part of code surrounding by a unique try/catch into several small parts each one surrounding by its try/catch.
In my opinion, there is no risk to simply merge.

teichsta added a commit that referenced this pull request Jul 6, 2015
Fix for #2789 - Freebox in bridge mode
@teichsta teichsta merged commit bc5c5fe into openhab:master Jul 6, 2015
@teichsta
Copy link
Member

teichsta commented Jul 6, 2015

Thanks @lolodomo!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants