Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add npm package-lock.json to .gitignore #3232

Closed
1 task done
elaguerta opened this issue Jul 22, 2021 · 1 comment · Fixed by #3237
Closed
1 task done

add npm package-lock.json to .gitignore #3232

elaguerta opened this issue Jul 22, 2021 · 1 comment · Fixed by #3237
Assignees
@elaguerta
Labels
bug a bug or issue eng issues related to site functionality that requires engineering
Milestone
[DevEn] Sprint 9

Comments

@elaguerta
Copy link
Contributor

elaguerta commented Jul 22, 2021 •
edited by zstix
Loading

The project uses yarn to manage dependencies.

Acceptance Criteria

  • .gitigore is updated to include package-lock.json so contributors don't accidentally commit this file to the repo when they accidentally use NPM 😎
@elaguerta elaguerta added good first issue bug a bug or issue eng issues related to site functionality that requires engineering labels Jul 22, 2021
@elaguerta elaguerta self-assigned this Jul 22, 2021
@jpvajda jpvajda added this to the [DevEn] Sprint 9 milestone Jul 22, 2021
@jpvajda jpvajda changed the title Issue: add npm package-lock.json to .gitignore add npm package-lock.json to .gitignore Jul 22, 2021
@jpvajda
Copy link

jpvajda commented Jul 22, 2021 •
edited
Loading

and my AC 🪓

@elaguerta elaguerta mentioned this issue Jul 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elaguerta elaguerta

Labels
bug a bug or issue eng issues related to site functionality that requires engineering
Projects
None yet
Milestone
[DevEn] Sprint 9
Development

Successfully merging a pull request may close this issue.

Add package.json to .gitignore newrelic/docs-website
2 participants
@jpvajda @elaguerta