Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Use correct output for connected nodes in schema view #10928

Conversation

elsmr
Copy link
Member

@elsmr elsmr commented Sep 23, 2024

Summary

Use correct output for connected nodes in schema view

image image

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/NODE-1642/schema-view-downstream-of-an-if-node-wrong-output-branch-is-used

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Sep 23, 2024
Copy link
Contributor

@ShireenMissi ShireenMissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Copy link

cypress bot commented Sep 24, 2024

n8n    Run #7016

Run Properties:  status check passed Passed #7016  •  git commit db17a1450b: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 elsmr 🗃️ e2e/*
Project n8n
Branch Review node-1642-schema-view-downstream-of-an-if-node-wrong-output-branch-is
Run status status check passed Passed #7016
Run duration 04m 26s
Commit git commit db17a1450b: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 elsmr 🗃️ e2e/*
Committer Elias Meire
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 430
View all changes introduced in this branch ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@ShireenMissi ShireenMissi merged commit ad60d49 into master Sep 24, 2024
33 checks passed
@ShireenMissi ShireenMissi deleted the node-1642-schema-view-downstream-of-an-if-node-wrong-output-branch-is branch September 24, 2024 15:14
@github-actions github-actions bot mentioned this pull request Sep 25, 2024
@janober
Copy link
Member

janober commented Sep 25, 2024

Got released with n8n@1.61.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants