Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TimePicker] Design review - Refine onClose and onAccept behavior #14739

Open
noraleonte opened this issue Sep 26, 2024 · 0 comments
Open

[TimePicker] Design review - Refine onClose and onAccept behavior #14739

noraleonte opened this issue Sep 26, 2024 · 0 comments
Labels
component: pickers This is the name of the generic UI component, not the React module! design This is about UI or UX design, please involve a designer

Comments

@noraleonte
Copy link
Contributor

noraleonte commented Sep 26, 2024

Extracted from #8964 point 3

Right now, pressing ok or closing the picker both call onAccept and persist the value. At a first glance, there isn’t an easy way to override this behavior and cancel the value selection on closing the picker for instance.

I think we need an easier way to control what happens on closing the pickers. Something like:

  • if there is an ok button, closing the picker resets the value.
  • users should be able to easily override this behavior with onClose and onAccept lifecycle methods for instance
  • if there is no ok button, the behavior should be the same as it is now.

Search keywords:

@github-actions github-actions bot added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Sep 26, 2024
@noraleonte noraleonte added component: pickers This is the name of the generic UI component, not the React module! design This is about UI or UX design, please involve a designer and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: pickers This is the name of the generic UI component, not the React module! design This is about UI or UX design, please involve a designer
Projects
None yet
Development

No branches or pull requests

1 participant