Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player Count does not increment /status #528

Closed
PJNorrisS1 opened this issue Nov 2, 2022 · 2 comments
Closed

Player Count does not increment /status #528

PJNorrisS1 opened this issue Nov 2, 2022 · 2 comments

Comments

@PJNorrisS1
Copy link

PJNorrisS1 commented Nov 2, 2022

I've noticed this a few times now, and can now recreate.

  • New Game
  • Game stopped, registration open
  • Register a new player
  • /status player_count is 0
  • No change after a while
  • Log in as admin
  • See player has registered
  • /status player_count still remains at 0
  • Load the score board
  • /status player_count is now at 1

The same occurs when I remove that player... it will only decrement when the scoreboard page is loaded.

Is there something happening when the scoreboard loads for the player_count string to update?

Thanks

@eljeffeg
Copy link
Collaborator

eljeffeg commented Nov 2, 2022

Yeah, the count was pulled from the scoreboard cache instead of directly from the database. I can update that as it's not a heavy query, but the count will include disabled teams too.

eljeffeg added a commit that referenced this issue Nov 2, 2022
@eljeffeg eljeffeg closed this as completed Nov 2, 2022
@PJNorrisS1
Copy link
Author

Ahh magic! Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants