Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have an option to clear out teams and users when resetting game #526

Closed
PJNorrisS1 opened this issue Oct 21, 2022 · 9 comments
Closed

Have an option to clear out teams and users when resetting game #526

PJNorrisS1 opened this issue Oct 21, 2022 · 9 comments

Comments

@PJNorrisS1
Copy link

Is is possible to have a checkbox on this screen:
image
that will delete all player names and team names? Please?

eljeffeg added a commit that referenced this issue Oct 25, 2022
@eljeffeg
Copy link
Collaborator

Option added

@PJNorrisS1
Copy link
Author

Legend! Thank you - much needed!

@PJNorrisS1
Copy link
Author

Just tested - getting this up:
image
I have tested it with game stopped, registration open and one user registered, with two administrator accounts registered. On that note, I assume the admin accounts will remain or will they be nuked too?

@PJNorrisS1
Copy link
Author

Also tried reset game -
image

@eljeffeg
Copy link
Collaborator

eljeffeg commented Oct 26, 2022

Admin accounts will remain. Do you see any error in the logs?

@eljeffeg
Copy link
Collaborator

eljeffeg commented Oct 26, 2022

Pushed a fix I hope - I had tried to persist the admin's session since I clear the memcached after the reset to kick off all users. However, I guess that caused an issue. So the admin will have to log back in after the reset.

@PJNorrisS1
Copy link
Author

Yup that fixed it! Nice one. Just one observation though... as this is a one way action with no undo button, I would perhaps suggest we have a confirmation box come up - Are you sure you want to RESET / Delete Game? and have the user enter a physical word in. As I said, there is no undo button :-). If not a physical word, perhaps just a yes no button? :-)

eljeffeg added a commit that referenced this issue Oct 26, 2022
@eljeffeg
Copy link
Collaborator

I tend to find over-proofing annoying, so I just added a confirmation yes no. If you go through the process to click the reset page, click the reset button, then click confirm - that's on you. lol

@PJNorrisS1
Copy link
Author

PJNorrisS1 commented Oct 26, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants