Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Open tasks] Replace storyboards with code #15

Closed
5 tasks done
misteu opened this issue Sep 30, 2022 · 9 comments
Closed
5 tasks done

[Open tasks] Replace storyboards with code #15

misteu opened this issue Sep 30, 2022 · 9 comments
Labels
enhancement New feature or request hacktober hacktoberfest help wanted Extra attention is needed

Comments

@misteu
Copy link
Owner

misteu commented Sep 30, 2022

GOAL

Replace all the storyboards with UIs created via code.

For not having one really huge branch, this will be split up in issues on a screen basis!

If you are interested in working on some screen, please comment on any of the open subtasks listed below.

Subtasks

WHY

Storyboards are slow to load in Xcode and they are harder to maintain compared to plain code.

AC

  • There should not be any storyboards in the app.

  • Optional
    First choice would be UIKit. It might make sense to also have a look whether it might make sense to start rewriting screens using SwiftUI. However, this will be way more work as it's a rewrite of everything.

@InsanelyHarsh
Copy link
Contributor

Hi @misteu, I would like to work on this issue.

@misteu
Copy link
Owner Author

misteu commented Oct 1, 2022

Hi @misteu, I would like to work on this issue.

Hi @InsanelyHarsh!
Thank you for your interest in the project :)

Please tell me which screen you want to translate into code. I will create an issue and assign it to you.

Have a great weekend!

@InsanelyHarsh
Copy link
Contributor

I think i will start with Add new Language View

@InsanelyHarsh
Copy link
Contributor

Assign me, I have replaced NewLanguageViewController with Code!

@misteu
Copy link
Owner Author

misteu commented Oct 1, 2022

Assign me, I have replaced NewLanguageViewController with Code!

Hi there and thank you!
I created this issue for the specific View Controller you worked on:
#17 (I think you need to comment there so that I can assign it to you)

@misteu misteu changed the title Replace storyboards with code [Open tasks] Replace storyboards with code Oct 11, 2022
@Kanishka3
Copy link
Contributor

I am taking up the HomeScreenViewController.

@misteu
Copy link
Owner Author

misteu commented Oct 27, 2022

Hi @Kanishka3 !
thanks for your interest! :)

Can you comment inside of the issue for this screen (#20)? I will assign it to you then.

Actually, it is already assigned to somebody else but I don't think there wasn't any work done yet.

Please comment there and maybe let's wait until tomorrow if he reacts.

@Kanishka3
Copy link
Contributor

Hi @Kanishka3 ! thanks for your interest! :)

Can you comment inside of the issue for this screen (#20)? I will assign it to you then.

Actually, it is already assigned to somebody else but I don't think there wasn't any work done yet.

Please comment there and maybe let's wait until tomorrow if he reacts.

Alright. Replies there. I am almost halfway done with the task.

@misteu
Copy link
Owner Author

misteu commented Dec 18, 2022

all done!

@misteu misteu closed this as completed Dec 18, 2022
@misteu misteu closed this as completed Dec 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktober hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants