Issue python#27194: superfluous truncate calls in tarfile.py slow dow…

…n extraction Patch by Jason Fried.
miss-islington · Jun 11, 2016 · e7f2748 · e7f2748
1 parent b5ad549
commit e7f2748
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/Lib/tarfile.py b/Lib/tarfile.py
@@ -2150,10 +2150,10 @@ def makefile(self, tarinfo, targetpath):
                 for offset, size in tarinfo.sparse:
                     target.seek(offset)
                     copyfileobj(source, target, size, ReadError)
+                target.seek(tarinfo.size)
+                target.truncate()
             else:
                 copyfileobj(source, target, tarinfo.size, ReadError)
-            target.seek(tarinfo.size)
-            target.truncate()
 
     def makeunknown(self, tarinfo, targetpath):
         """Make a file from a TarInfo object with an unknown type

diff --git a/Misc/ACKS b/Misc/ACKS
@@ -458,6 +458,7 @@ Stefan Franke
 Martin Franklin
 Kent Frazier
 Bruce Frederiksen
+Jason Fried
 Robin Friedrich
 Bradley Froehle
 Ivan Frohne