Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies #4342

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Update dependencies #4342

merged 1 commit into from
Jul 17, 2024

Conversation

danegsta
Copy link
Contributor

Update several outdated dependencies to latest versions. Resolves #4330.

@danegsta danegsta requested a review from a team as a code owner July 17, 2024 21:24
bwateratmsft
bwateratmsft approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@bwateratmsft bwateratmsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did the VSIX grow or shrink with the new packages? Probably grew but how much would be interesting to know.

@danegsta
Copy link
Contributor Author

Did the VSIX grow or shrink with the new packages? Probably grew but how much would be interesting to know.

Seems like it might be as much as 1MB more, which isn't great, but that's comparing the vsix from a pipeline build to a local dev build, so take with a grain of salt.

@danegsta danegsta merged commit 0c885ae into main Jul 17, 2024
2 checks passed
@danegsta danegsta deleted the dev/danegsta/updateDependencies branch July 17, 2024 22:14
@danegsta
Copy link
Contributor Author

In the official build it actually shrunk by about 0.01 MB, so looks to be basically the same size as before.

@microsoft microsoft locked and limited conversation to collaborators Sep 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bwateratmsft bwateratmsft bwateratmsft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update @vscode/extension-telemetry dependency
2 participants
@danegsta @bwateratmsft