Pad slashes in /regex/ syntax to provide parity with $regex syntax #933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenWeatherford
requested changes
Nov 9, 2018
|
Added tests. |
test/mongoGetCommand.test.ts
Outdated
| }); | ||
|
|
||
| test("test regular expression parsing interoperability - newline", () => { | ||
| let text1 = `db.test1.beep.find({ sku: /ker\\n/g })`; // equivalent to user typing out /ker\b/ |
There was a problem hiding this comment.
nit your comment is wrong
test/mongoGetCommand.test.ts
Outdated
| assert.deepEqual([generatedRegExp1.flags, generatedRegExp1.source], ["g", "ker\\n"]); | ||
| }); | ||
| test("test regular expression parsing interoperability - carriage return", () => { | ||
| let text1 = `db.test1.beep.find({ sku: /ker\\r/g })`; // equivalent to user typing out /ker\b/ |
There was a problem hiding this comment.
nit your comment is wrong
src/mongo/MongoScrapbook.ts
Outdated
| @@ -404,7 +396,8 @@ class FindMongoCommandsVisitor extends MongoVisitor<MongoCommand[]> { | |||
| // It is intended for the errors thrown here to be handled by the catch block. | |||
| let tokenObject = new RegExp(pattern, flags); | |||
| tokenObject = tokenObject; | |||
| return { $regex: pattern, $options: flags }; | |||
| // we are passing back a $regex annotation, hence we ensure parity wit the $regex syntax | |||
| return { $regex: this.padRegexEscape(pattern), $options: flags }; | |||
StephenWeatherford
approved these changes
Nov 11, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.