Updated deprecated packages "azure-arm-cosmosdb" and "azure-arm-postgresql" #1730
Conversation
…ExperienceLabel; updated @types/node and @types/vscode
package.json
Outdated
| @@ -6,7 +6,7 @@ | |||
| "displayName": "Azure Databases", | |||
| "description": "Create, browse, and update globally distributed, multi-model databases in Azure.", | |||
| "engines": { | |||
| "vscode": "^1.40.0" | |||
| "vscode": "^1.50.0" | |||
There was a problem hiding this comment.
Not quite - when you update the VS Code engine, you always want to be on the minimum version you need (in our case 1.48.0). Otherwise, people on older versions of VS Code won't get the update to our extension until they update VS Code, which just slows down the adoption of our latest extension
package.json
Outdated
| "@azure/cosmos": "^3.6.3", | ||
| "@types/documentdb": "^1.10.2", | ||
| "@types/fs-extra": "^8.1.0", | ||
| "@types/keytar": "4.0.1", | ||
| "@types/mocha": "^7.0.2", | ||
| "@types/mongodb": "^3.3.2", | ||
| "@types/node": "^12.0.0", | ||
| "@types/vscode": "1.40.0", | ||
| "@types/node": "^14.14.5", |
There was a problem hiding this comment.
You should keep the Node types at 12. Our version of Node is controlled by VS Code. You can find that info by doing "Code -> About Visual Studio Code" (the minor/patch version doesn't really matter, just the major version). For example:
| @@ -6,7 +6,7 @@ | |||
| "displayName": "Azure Databases", | |||
There was a problem hiding this comment.
In other repos, I had to add this to get the build to pass when updating the azure packages:
https://github.com/microsoft/vscode-azurefunctions/blob/main/tsconfig.json#L23
May or may not help the build error you're seeing for this PR
There was a problem hiding this comment.
It works, thanks! I was getting a 'async' modifier cannot be used in an ambient context error in the vscode-azureextensionui package.
Deprecated packages:
azure-arm-cosmosdb,azure-arm-postgresql-->@azure/arm-cosmosdb,@azure/arm-postgresqlDependencies:
vscode-azureextensionui@latest,@azure/ms-rest-js,@azure/ms-rest-azure,@azure/arm-resources,@azure/ms-rest-nodeauth