-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Postgres to existing CosmosDB "Create Account" command #1445
Conversation
Using Azure Database "server" instead "resource" seems to get confusing within the code given the use of DatabaseAccount for CosmosDB and server for Postgres. Another option is to use "server" for output and "resource" for the code? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using Azure Database "server" instead "resource" seems to get confusing within the code given the use of DatabaseAccount for CosmosDB and server for Postgres. Another option is to use "server" for output and "resource" for the code?
I agree that "resource" is a better generic name for both accounts and servers but I think it's easier to understand when everything uses the same terminology. And since we chose to call the command "Create Server..." I would vote for just using "server" internally.
@EricJizbaMSFT may have some thoughts on this
I think I agree with Will that consistently using Server would be the least confusing |
Does that mean renaming "DatabaseAccount" in code for CosmosDB or just renaming for any output values? |
I would stick with DatabaseAccount for anything specific to Cosmos DB |
No description provided.