Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Postgres to existing CosmosDB "Create Account" command #1445

Merged
merged 9 commits into from
May 20, 2020

Conversation

neelip
Copy link
Member

@neelip neelip commented Apr 30, 2020

No description provided.

@neelip neelip requested a review from a team as a code owner April 30, 2020 18:52
src/CosmosDBExperiences.ts Outdated Show resolved Hide resolved
src/CosmosDBExperiences.ts Show resolved Hide resolved
src/CosmosDBExperiences.ts Show resolved Hide resolved
src/CosmosDBExperiences.ts Show resolved Hide resolved
src/CosmosDBExperiences.ts Show resolved Hide resolved
src/CosmosDBExperiences.ts Show resolved Hide resolved
@neelip
Copy link
Member Author

neelip commented May 11, 2020

Using Azure Database "server" instead "resource" seems to get confusing within the code given the use of DatabaseAccount for CosmosDB and server for Postgres. Another option is to use "server" for output and "resource" for the code?

Copy link
Contributor

@wwlorey wwlorey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using Azure Database "server" instead "resource" seems to get confusing within the code given the use of DatabaseAccount for CosmosDB and server for Postgres. Another option is to use "server" for output and "resource" for the code?

I agree that "resource" is a better generic name for both accounts and servers but I think it's easier to understand when everything uses the same terminology. And since we chose to call the command "Create Server..." I would vote for just using "server" internally.

@EricJizbaMSFT may have some thoughts on this

package.json Outdated Show resolved Hide resolved
src/tree/SubscriptionTreeItem.ts Outdated Show resolved Hide resolved
@ejizba
Copy link
Member

ejizba commented May 14, 2020

I think I agree with Will that consistently using Server would be the least confusing

@neelip
Copy link
Member Author

neelip commented May 14, 2020

Does that mean renaming "DatabaseAccount" in code for CosmosDB or just renaming for any output values?

@ejizba
Copy link
Member

ejizba commented May 14, 2020

I would stick with DatabaseAccount for anything specific to Cosmos DB

src/tree/AzureDBAPIStep.ts Outdated Show resolved Hide resolved
src/tree/SubscriptionTreeItem.ts Outdated Show resolved Hide resolved
src/tree/AzureDBAPIStep.ts Outdated Show resolved Hide resolved
src/tree/AzureDBAPIStep.ts Show resolved Hide resolved
@neelip neelip merged commit 01d396c into master May 20, 2020
@neelip neelip deleted the neelima/merge-create-account-commands branch May 20, 2020 21:04
@github-actions github-actions bot locked and limited conversation to collaborators Apr 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants