Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ts Move to a new file doesn't respect importModuleSpecifier setting #59649

Closed
tjx666 opened this issue Aug 15, 2024 · 2 comments · Fixed by #59670
Closed

ts Move to a new file doesn't respect importModuleSpecifier setting #59649

tjx666 opened this issue Aug 15, 2024 · 2 comments · Fixed by #59670
Assignees
Labels
Bug A bug in TypeScript Fix Available A PR has been opened for this issue

Comments

@tjx666
Copy link

tjx666 commented Aug 15, 2024

@mjbvz @justschen

reproduce repo: https://github.com/tjx666/ts-none-relative-reproduce

a little like microsoft/vscode#160304.

setting:

{
    "typescript.tsdk": "node_modules/typescript/lib",
    "javascript.preferences.importModuleSpecifier": "non-relative",
    "typescript.preferences.importModuleSpecifier": "non-relative"
}

problem

image image

expect

image

screen recoding

2024-08-15.18.17.13.mov

versions

"typescript": "^5.5.4"
Version: 1.92.1 (Universal)
Commit: eaa41d57266683296de7d118f574d0c2652e1fc4
Date: 2024-08-07T20:16:39.455Z
Electron: 30.1.2
ElectronBuildId: 9870757
Chromium: 124.0.6367.243
Node.js: 20.14.0
V8: 12.4.254.20-electron.0
OS: Darwin arm64 23.6.0
@mjbvz mjbvz transferred this issue from microsoft/vscode Aug 15, 2024
@RyanCavanaugh RyanCavanaugh added the Bug A bug in TypeScript label Aug 16, 2024
@RyanCavanaugh RyanCavanaugh assigned navya9singh and unassigned mjbvz Aug 16, 2024
@RyanCavanaugh RyanCavanaugh added this to the TypeScript 5.7.0 milestone Aug 16, 2024
@typescript-bot typescript-bot added the Fix Available A PR has been opened for this issue label Aug 17, 2024
@DanielRosenwasser
Copy link
Member

Thanks @a-tarasyuk!

@dgreensp
Copy link

Does this also fix the refactoring changes made when you move a file to a different folder in the explorer?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug in TypeScript Fix Available A PR has been opened for this issue
Projects
None yet
7 participants