Dev Container: Get 'debian-docker.sh' from github, fix nvm, prune already installed #3524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DLehenbauer
commented
Sep 4, 2020
| @@ -2,17 +2,17 @@ | |||
| # export PATH=$HOME/bin:/usr/local/bin:$PATH | |||
There was a problem hiding this comment.
Except as noted, all .zshrc changes are due to having used an old version of 'oh-my-zsh'.
DLehenbauer
commented
Sep 4, 2020
| if [ "$(stat -c '%U' $NVM_DIR)" != "node" ]; then | ||
| sudo chown -R node:root $NVM_DIR | ||
| fi | ||
| if [ "$(stat -c '%U' /usr/local/share/npm-global)" != "node" ]; then sudo chown -R 1000:root /usr/local/share/npm-global /usr/local/share/nvm; fi |
There was a problem hiding this comment.
This missing bit is required for NVM
DLehenbauer
commented
Sep 4, 2020
| FROM mcr.microsoft.com/vscode/devcontainers/javascript-node:${NODE_VERSION} | ||
|
|
||
| # Avoid warnings by switching to noninteractive | ||
| ENV DEBIAN_FRONTEND=noninteractive | ||
|
|
||
| COPY library-scripts/*.sh /tmp/library-scripts/ | ||
|
|
There was a problem hiding this comment.
We now get the 'debian-docker.sh' install script from GitHub instead of checking it in.
DLehenbauer
commented
Sep 4, 2020
| # https://jilles.me/badassify-your-terminal-and-shell/ | ||
| # https://billgrant.io/post/2019-05-05-vsremote/ | ||
| && apt-get install -y zsh \ | ||
| wget \ |
There was a problem hiding this comment.
All of the above has already been done in the base image. We don't need to do it again.
DLehenbauer
commented
Sep 4, 2020
| git \ | ||
| curl \ | ||
| g++ | ||
|
|
There was a problem hiding this comment.
Also already done in the debian base image. (Uses packages and everything.)
DLehenbauer
changed the title
ghost
added
the
tanviraumi
approved these changes
Sep 4, 2020
|
Thanks, @tanviraumi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few more tweaks to our dev container...