Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Likes and comments app #3286

Merged
merged 17 commits into from
Sep 3, 2020
Merged

Likes and comments app #3286

merged 17 commits into from
Sep 3, 2020

Conversation

sumedhb1995
Copy link
Contributor

@sumedhb1995 sumedhb1995 commented Aug 21, 2020 •
edited
Loading

Takes the likes-and-comments example fluid object and converts it a Fluid app

skylerjokiel
skylerjokiel reviewed Aug 31, 2020
View reviewed changes
Copy link
Contributor

@skylerjokiel skylerjokiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some comments. The example looks good. The only thing I really want resolution on is why this example builds differently then others in the repo. I'm guessing it's so that it can be pulled out easier but I'm not sure if that causes other issues.

@sumedhb1995
Copy link
Contributor Author

@skylerjokiel I was confused about how the build for these apps examples should be in the monorepo, since they are different from the examples repo. I wasn't sure which model to follow...
I built this off of the draft-js example because I wasn't able to get spaces to run but I can try again. I might have been messing up the package installation?
I don't have a preference in either direction. If the apps are also supposed to be installed as part of the monorepo installation, then I can switch this over

skylerjokiel
skylerjokiel approved these changes Sep 3, 2020
View reviewed changes
Copy link
Contributor

@skylerjokiel skylerjokiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍁

@sumedhb1995 sumedhb1995 merged commit 863a8c1 into microsoft:main Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micahgodbolt micahgodbolt micahgodbolt left review comments

@skylerjokiel skylerjokiel skylerjokiel approved these changes

@ChumpChief ChumpChief Awaiting requested review from ChumpChief

@curtisman curtisman Awaiting requested review from curtisman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sumedhb1995 @micahgodbolt @skylerjokiel