Update old version of mocha-test-setup used by tinylicious #21947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
base: main
tylerbutler
approved these changes
Jul 19, 2024
| "@fluidframework/build-common": "^2.0.3", | ||
| "@fluidframework/eslint-config-fluid": "^5.2.0", | ||
| "@fluidframework/mocha-test-setup": "~2.0.0-internal.6.2.0", |
There was a problem hiding this comment.
Ha, this range was always wrong, too. UGH.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This updates the last use of a
2.0.0-internal.x.x.xpackage in our repo, mocha-test-setup used by tinylicious.With server using client packages (and client using server packages), it's easy for server to fall behind on the versions of client it consumes: this updates one particularly out of date case.
Reviewer Guidance
The review process is outlined on this wiki page.