Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Patch socket.io packages for node16 moduleResolution #18170

Merged
merged 6 commits into from
Nov 6, 2023
Merged

build: Patch socket.io packages for node16 moduleResolution #18170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ebd6eee
build: Patch socket.io packages
tylerbutler Nov 6, 2023
570c222
revert
tylerbutler Nov 6, 2023
ac0a6a9
revert
tylerbutler Nov 6, 2023
bd04fbf
readme
tylerbutler Nov 6, 2023
068ae63
Merge branch 'main' into module-resolution-node16-groundwork
tylerbutler Nov 6, 2023
40b0774
Merge branch 'main' into module-resolution-node16-groundwork
tylerbutler Nov 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,6 +365,10 @@
"@types/node",
"fluid-framework"
]
},
"patchedDependencies": {
"socket.io-client@4.7.2": "patches/socket.io-client@4.7.2.patch",
"engine.io-client@6.5.2": "patches/engine.io-client@6.5.2.patch"
}
}
}
26 changes: 26 additions & 0 deletions patches/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
# Dependency patches

The files in this folder are patches for packages we depend on within the repo. The patches are created using
[pnpm patch](https://pnpm.io/cli/patch), and pnpm applies the patches automatically when running install.

## Patch details

Each patch is described here, along with any relevant links to issues or PRs and any additional relevant details.

### engine.io-client

This patch updates the `exports` field in package.json to be correct for TypeScript projects using
`moduleResolution: node16`.

It applies the changes covered in this PR: https://github.com/socketio/engine.io-client/pull/711

As soon as a version of the package is released with the changes in that PR, this patch can be removed.

### socket.io-client

This patch updates the `exports` field in package.json to be correct for TypeScript projects using
`moduleResolution: node16`.

It applies the changes covered in this PR: https://github.com/socketio/socket.io-client/pull/1595

As soon as a version of the package is released with the changes in that PR, this patch can be removed.
Loading