feat(fluid-build): Support external config #14215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: contributor experience
base: main
tylerbutler
changed the title
curtisman
approved these changes
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The config used by fluid-build is stored in the
fluidBuildnode in package.json. The config is loaded using custom code, which makes it more difficult to move the config to an external config file, which we would like to do to minimize churn in package.json.This change uses cosmiconfig to load the config, replacing the custom code. This means the config can now be in an external fluidBuild.config.cjs or fluidBuild.config.js file, in addition to the package.json node. The files are checked first; package.json is the fallback.
This PR does not change where the config is stored. That can be done in a future change.