Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move PropertyDDS examples to @fluid-example scope and make private #14206

Merged
merged 2 commits into from
Feb 17, 2023

Conversation

ChumpChief
Copy link
Contributor

Examples should use the example scope, and we should avoid publishing them to NPM. This change moves the PropertyDDS examples to that scope accordingly and marks them private.

@ChumpChief ChumpChief requested review from msfluid-bot and a team as code owners February 16, 2023 01:50
@github-actions github-actions bot added the base: main PRs targeted against main branch label Feb 16, 2023
@ChumpChief ChumpChief merged commit 77a6b43 into microsoft:main Feb 17, 2023
@ChumpChief ChumpChief deleted the PropertyDDSExampleHide branch February 17, 2023 20:14
tylerbutler added a commit that referenced this pull request Feb 18, 2023
PR #14206 renamed some packages to use the fluid-example scope. However,
it didn't update the references to those packages in code/package.json.
This PR corrects that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: dds: propertydds base: main PRs targeted against main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants