Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to using ICodeDetailsLoader while ingesting code loader types from container definitions #9033

Closed
Tracked by #8193
ssimic2 opened this issue Feb 7, 2022 · 4 comments
Assignees
Labels
Milestone

Comments

@ssimic2
Copy link

ssimic2 commented Feb 7, 2022

At this point we should be able to fully consume code loader types from container definitions.

  1. Consume code loader types from @fluidframework/container-definitions
  2. Transition FF codebase to use ICodeDetailsLoader instead of ICodeLoader.
@ssimic2 ssimic2 added the api label Feb 7, 2022
@ssimic2 ssimic2 added this to the February 2022 milestone Feb 7, 2022
@ssimic2 ssimic2 self-assigned this Feb 7, 2022
@ssimic2 ssimic2 mentioned this issue Feb 7, 2022
7 tasks
@ssimic2 ssimic2 changed the title Move to ICodeDetailsLoader and complete associated cleanup Move to ICodeDetailsLoader and consume code loader types from container definitions Feb 7, 2022
@ssimic2 ssimic2 changed the title Move to ICodeDetailsLoader and consume code loader types from container definitions Move to using ICodeDetailsLoader while ingesting code loader types from container definitions Feb 7, 2022
@ssimic2
Copy link
Author

ssimic2 commented Feb 24, 2022

Hey @sdeshpande3 - Are you pulling out "Transition FF codebase to use ICodeDetailsLoader instead of ICodeLoader." as a separate item here ? I think we concluded we will have to wait to transition definitions.

@sonalivdeshpande
Copy link
Contributor

Hey @sdeshpande3 - Are you pulling out "Transition FF codebase to use ICodeDetailsLoader instead of ICodeLoader." as a separate item here ? I think we concluded we will have to wait to transition definitions.

Yes, this issue essentially captures "Transition FF codebase to use ICodeDetailsLoader instead of ICodeLoader" but this would have to wait until driver-definitions does not transition to start using IContainerPackageInfo.

@heliocliu heliocliu modified the milestones: February 2022, March 2022 Feb 24, 2022
@ssimic2 ssimic2 removed their assignment Mar 10, 2022
@sonalivdeshpande
Copy link
Contributor

The changes are expected to go in next branch -- release 0.59

@skylerjokiel
Copy link
Contributor

Closing since it was moved to Done on the board. @sonalivdeshpande follow up with me if this is still active.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

4 participants