Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow step intervals at finer than whole second granularity for Wavefront #2175

Closed
shakuzen opened this issue Jul 3, 2020 · 0 comments
Closed

Allow step intervals at finer than whole second granularity for Wavefront #2175

shakuzen opened this issue Jul 3, 2020 · 0 comments
Labels
enhancement A general enhancement registry: wavefront A Wavefront (Tanzu Observability) Registry related issue release notes Noteworthy change to call out in the release notes
Milestone
1.6.0

Comments

@shakuzen
Copy link
Member

shakuzen commented Jul 3, 2020 •
edited
Loading

See #2173 where it was fixed that we were not using the configured step from WavefrontConfig to configure the Wavefront SDK's client. Until version 2.4 of the Wavefront SDK, it didn't allow setting a flushInterval in anything but whole seconds. It is not a common use case to need more than whole second granularity, but since we take an arbitrary Duration for step in the Config, we should align more closely with that to avoid confusing users. It will require the wavefront sdk used is version 2.4 or later, which we should call out in the release notes.
@shakuzen shakuzen added enhancement A general enhancement registry: wavefront A Wavefront (Tanzu Observability) Registry related issue release notes Noteworthy change to call out in the release notes labels Jul 3, 2020
@shakuzen shakuzen added this to the 1.6.0 milestone Jul 3, 2020
This was referenced Jun 26, 2021
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement A general enhancement registry: wavefront A Wavefront (Tanzu Observability) Registry related issue release notes Noteworthy change to call out in the release notes
Projects
None yet
Milestone
1.6.0
Development

No branches or pull requests
1 participant
@shakuzen