Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sidebar): add Colors category to Guides #9936

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

bsmth
Copy link
Member

@bsmth bsmth commented Nov 3, 2023

Summary

This PR adds a new section for the CSSRef sidebar which links to some guides on Colors

Problem

We do not surface Colors guides in CSS section as readily as we could

Solution

Highlight existing guides in the CSS Sidebar. Adds links to:


Screenshots

Before

image

After

image

How did you test this change?

yarn && yarn dev

@bsmth bsmth requested a review from a team as a code owner November 3, 2023 12:05
@github-actions github-actions bot added the macros tracking issues related to kumascript macros label Nov 3, 2023
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, but my concern is that the two accessibility URLs have a different sidebar, and this might be confusing for users.

@bsmth
Copy link
Member Author

bsmth commented Nov 3, 2023

two accessibility URLs have a different sidebar, and this might be confusing for users.

Yes, I think this is a good thing to watch out for, I was also considering this, but I think it's reasonable given we're surfacing important info under that topic. It would be great to watch closely and revert or fix if this is confusing for readers.

@caugner caugner changed the title feat(sidebar): Add 'Colors' category to Guides feat(sidebar): add Colors category to Guides Nov 3, 2023
@caugner caugner merged commit 20e5826 into mdn:main Nov 3, 2023
9 checks passed
@bsmth bsmth deleted the css-guides-colors branch November 6, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
macros tracking issues related to kumascript macros sidebar content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants