Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(macros): delete {{SectionOnPage}} macro #9436

Merged
merged 1 commit into from
Oct 9, 2023
Merged

chore(macros): delete {{SectionOnPage}} macro #9436

merged 1 commit into from
Oct 9, 2023

Conversation

yin1999
Copy link
Member

@yin1999 yin1999 commented Aug 4, 2023

Summary

We have removed this macro from translated-content. Let's remove it from yari.

I've run rg to verify this :)

rg -il "SectionOnPage" | wc -l # got 0

image

@github-actions github-actions bot added the macros tracking issues related to kumascript macros label Aug 4, 2023
@caugner caugner merged commit 54dce18 into mdn:main Oct 9, 2023
9 checks passed
@caugner
Copy link
Contributor

caugner commented Oct 9, 2023

Thanks @yin1999! 🎉

@github-actions github-actions bot mentioned this pull request Oct 9, 2023
Merged
@yin1999 yin1999 deleted the patch-1 branch October 9, 2023 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caugner caugner caugner approved these changes

Assignees
No one assigned
Labels
macros tracking issues related to kumascript macros
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yin1999 @caugner