chore: add alias vue -> markup to enable syntax highlighting #8945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We have build errors that
vueis not a detected language. There is no support forvuein Prism, an alternative is to usemarkupwhich is supported without additional Yari dependencies. Adding an alias will allow us to highlight the language and preserve Prettier linting in content.Problem
Prism does not support
vueas a language, see:Solution
Add an alias for
markupso that the language will be highlighted and Prettier can still format the examples.Screenshots
Before
After
How did you test this change?
On http://localhost:5042/en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/Vue_computed_properties
Other:
Opening this one in favor of mdn/content#26987