Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change vue -> markup for syntax highlighting #26987

Closed
wants to merge 1 commit into from

Conversation

bsmth
Copy link
Member

@bsmth bsmth commented May 26, 2023

Description

This PR changes instances of vue to markup in code blocks.

```vue
// this is not a detected language
```


```markup
// loaded by Prism
```

Motivation

We have build errors that vue is not a detected language. There is no support for vue in Prism, an alternative is to use markup which is supported without additional Yari dependencies - this is acceptable for the 4 instances of vue code blocks IMO.

Related issues and pull requests

@bsmth bsmth requested a review from a team as a code owner May 26, 2023 11:43
@bsmth bsmth requested review from chrisdavidmills and removed request for a team May 26, 2023 11:43
@github-actions github-actions bot added the Content:Learn Learning area docs label May 26, 2023
@github-actions
Copy link
Contributor

@Josh-Cena
Copy link
Member

I see no point to change the language meta. Prettier supports formatting for Vue, and we may even lint these code blocks one day. Can we add a mapping in Yari?

@bsmth
Copy link
Member Author

bsmth commented May 26, 2023

Can we add a mapping in Yari?

Indeed we could add an alias for vue resolving to markup for the syntax highlighting part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Learn Learning area docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants