Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing CMake build implementation #11049

Closed
HTRamsey opened this issue Feb 11, 2024 · 1 comment
Closed

Fixing CMake build implementation #11049

HTRamsey opened this issue Feb 11, 2024 · 1 comment
Assignees

Comments

@HTRamsey
Copy link
Collaborator

HTRamsey commented Feb 11, 2024

Here are a few issues to resolve getting android to build with cmake:

  • SDL inclusion is set to required with Android.
  • OpenGL inclusion is set to required with Android.
  • AddQtAndroidApk.cmake needs to be updated for Qt6, you don't need the custom call to androiddeployqt if qt_add_executable is setup correctly.

Some additional notes:

  • Make cmake_minimum_required to 3.21.1 (required for MacOS).
  • For builds other than Android, qt_generate_deploy_qml_app_script can be used to simplify deploying.
  • qt_add_library should be used instead of add_library
  • qt_add_plugin can be used for the QtLocation portion instead of add_library
  • qt_add_qml_module should be used instead of add_custom_target
  • If qmake is ever dropped fully, set_source_files_properties with QT_QML_SINGLETON_TYPE can be used to register qml singletons
  • If qmake is ever dropped fully, most submodules and provided windows libraries can be dropped for a fetchcontent.
  • qt_standard_project_setup should be called
@DonLakeFlyer DonLakeFlyer self-assigned this Feb 14, 2024
@HTRamsey
Copy link
Collaborator Author

@DonLakeFlyer I will fix CMake stuff and test with Android & Linux after some of my other stuff.

@HTRamsey HTRamsey self-assigned this Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants