Skip to content

Commit

Permalink
Updates library versions, adds possibility to use custom gPlus button
Browse files Browse the repository at this point in the history
  • Loading branch information
maksim88 committed Jun 5, 2017
1 parent 8b2a1d2 commit 990d7cb
Show file tree
Hide file tree
Showing 8 changed files with 22 additions and 50 deletions.
5 changes: 0 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -74,11 +74,6 @@ twitterButton = (TwitterLoginButton) findViewById(R.id.twitter_login_button);
twitter.requestLogin(twitterButton, this);
```

You also need to make sure to add the Fabric API Key your manifest:
```
<meta-data android:name="io.fabric.ApiKey" android:value="@string/fabric_app_id"/>
```

Google Plus Connection
--------

Expand Down
2 changes: 1 addition & 1 deletion build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ buildscript {
jcenter()
}
dependencies {
classpath 'com.android.tools.build:gradle:2.3.0'
classpath 'com.android.tools.build:gradle:2.3.2'
classpath 'com.google.gms:google-services:3.0.0'
}
}
Expand Down
14 changes: 7 additions & 7 deletions library/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ apply plugin: 'com.android.library'
ext {
PUBLISH_GROUP_ID = 'com.maksim88'
PUBLISH_ARTIFACT_ID = 'EasyLogin'
PUBLISH_VERSION = 'v0.4'
PUBLISH_VERSION = 'v0.5'
}

android {
Expand Down Expand Up @@ -34,13 +34,13 @@ android {
dependencies {
compile fileTree(dir: 'libs', include: ['*.jar'])
testCompile 'junit:junit:4.12'
compile 'com.android.support:appcompat-v7:25.2.0'
compile 'com.android.support:appcompat-v7:25.3.1'
// dependency with older facebook tools
compile 'com.android.support:cardview-v7:25.2.0'
compile 'com.android.support:customtabs:25.2.0'
compile 'com.facebook.android:facebook-android-sdk:4.20.0'
compile 'com.google.android.gms:play-services-auth:10.2.0'
compile('com.twitter.sdk.android:twitter:2.3.2@aar') {
compile 'com.android.support:cardview-v7:25.3.1'
compile 'com.android.support:customtabs:25.3.1'
compile 'com.facebook.android:facebook-android-sdk:4.23.0'
compile 'com.google.android.gms:play-services-auth:10.2.6'
compile('com.twitter.sdk.android:twitter-core:3.0.0@aar') {
transitive = true;
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
import com.google.android.gms.auth.api.signin.GoogleSignInOptions;
import com.google.android.gms.auth.api.signin.GoogleSignInResult;
import com.google.android.gms.common.ConnectionResult;
import com.google.android.gms.common.SignInButton;
import com.google.android.gms.common.api.CommonStatusCodes;
import com.google.android.gms.common.api.GoogleApiClient;
import com.google.android.gms.common.api.OptionalPendingResult;
Expand All @@ -42,7 +41,7 @@ public class GooglePlusNetwork extends SocialNetwork implements GoogleApiClient.

private WeakReference<Activity> mActivity;

private WeakReference<SignInButton> mSignInButton;
private WeakReference<View> mSignInButton;

public GooglePlusNetwork(Activity activity) {

Expand Down Expand Up @@ -167,7 +166,7 @@ public void onConnectionFailed(@NonNull ConnectionResult connectionResult) {
mListener.onError(getNetwork(), getStatusCodeString(connectionResult.getErrorCode()));
}

public void setSignInButton(SignInButton button) {
public void setSignInButton(View button) {
mSignInButton = new WeakReference<>(button);
mSignInButton.get().setOnClickListener(new View.OnClickListener() {
@Override
Expand Down
Original file line number Diff line number Diff line change
@@ -1,30 +1,25 @@
package com.maksim88.easylogin.networks;

import android.app.Activity;
import android.content.Context;
import android.content.Intent;
import android.os.Build;
import android.webkit.CookieManager;
import android.webkit.CookieSyncManager;
import android.util.Log;

import com.maksim88.easylogin.AccessToken;
import com.maksim88.easylogin.listener.OnLoginCompleteListener;
import com.twitter.sdk.android.Twitter;
import com.twitter.sdk.android.core.Callback;
import com.twitter.sdk.android.core.DefaultLogger;
import com.twitter.sdk.android.core.Result;
import com.twitter.sdk.android.core.Twitter;
import com.twitter.sdk.android.core.TwitterAuthConfig;
import com.twitter.sdk.android.core.TwitterAuthToken;
import com.twitter.sdk.android.core.TwitterConfig;
import com.twitter.sdk.android.core.TwitterCore;
import com.twitter.sdk.android.core.TwitterException;
import com.twitter.sdk.android.core.TwitterSession;
import com.twitter.sdk.android.core.identity.TwitterLoginButton;

import java.lang.ref.WeakReference;

import io.fabric.sdk.android.Fabric;

import static com.facebook.FacebookSdk.getApplicationContext;

/**
* Created by maksim on 14.02.16.
*/
Expand Down Expand Up @@ -60,7 +55,11 @@ public void failure(TwitterException e) {

public TwitterNetwork(Activity activity, String consumerKey, String consumerSecret) {
TwitterAuthConfig authConfig = new TwitterAuthConfig(consumerKey, consumerSecret);
Fabric.with(activity, new Twitter(authConfig));
TwitterConfig config = new TwitterConfig.Builder(activity.getApplicationContext())
.logger(new DefaultLogger(Log.DEBUG))
.twitterAuthConfig(authConfig)
.build();
Twitter.initialize(config);
}

@Override
Expand Down Expand Up @@ -88,9 +87,7 @@ private void requestLogin(TwitterLoginButton button) {
public void logout() {
TwitterSession twitterSession = TwitterCore.getInstance().getSessionManager().getActiveSession();
if (twitterSession != null) {
clearCookies(getApplicationContext());
Twitter.getSessionManager().clearActiveSession();
Twitter.logOut();
TwitterCore.getInstance().getSessionManager().clearActiveSession();
mLoginButton.get().setEnabled(true);
}
}
Expand All @@ -111,20 +108,4 @@ public void onActivityResult(int requestCode, int resultCode, Intent data) {
mLoginButton.get().onActivityResult(requestCode, resultCode, data);
}
}

@SuppressWarnings("deprecation")
private void clearCookies(Context context) {
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP_MR1) {
CookieManager.getInstance().removeAllCookies(null);
CookieManager.getInstance().flush();
} else {
CookieSyncManager cookieSyncMngr = CookieSyncManager.createInstance(context);
cookieSyncMngr.startSync();
CookieManager cookieManager = CookieManager.getInstance();
cookieManager.removeAllCookie();
cookieManager.removeSessionCookie();
cookieSyncMngr.stopSync();
cookieSyncMngr.sync();
}
}
}
2 changes: 0 additions & 2 deletions sample/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@

<meta-data android:name="com.facebook.sdk.ApplicationId" android:value="@string/facebook_app_id"/>

<meta-data android:name="io.fabric.ApiKey" android:value="@string/fabric_app_id"/>

<activity
android:name=".MainActivity"
android:label="@string/title_activity_main"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ public class MainActivity extends AppCompatActivity implements OnLoginCompleteLi

private SignInButton gPlusButton;

private TwitterLoginButton twitterButton;
private TwitterLoginButton twitterButton;

FacebookNetwork facebook;

Expand Down Expand Up @@ -135,7 +135,7 @@ public void onLoginSuccess(SocialNetwork.Network network) {
@Override
public void onError(SocialNetwork.Network socialNetwork, String errorMessage) {
Log.e("MAIN", "ERROR!" + socialNetwork + "|||" + errorMessage);
Toast.makeText(getApplicationContext(), errorMessage,
Toast.makeText(getApplicationContext(), socialNetwork.name() + ": " + errorMessage,
Toast.LENGTH_SHORT).show();
}

Expand Down
1 change: 0 additions & 1 deletion sample/src/main/res/values/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,4 @@
<string name="app_name">EasyLogin Sample</string>
<string name="title_activity_main">MainActivity</string>
<string name="facebook_app_id">TO BE CHANGED</string>
<string name="fabric_app_id">TO BE CHANGED</string>
</resources>

0 comments on commit 990d7cb

Please sign in to comment.