Do not include compat-5.3.h in luv header file #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exposing the compat-5.3.h header file directly in the luv.h header file is not a good idea, because it causes redefinition errors when building, for example latest luvi version 2.8.0, with a shared luv library and LuaJIT 2.0.5. Therefore, include the compat header file in the luv.c source file. Note, that luvi version 2.8.0 still fails to build against the shared luv library using LuaJIT 2.0.5, as it does use `luaL_newlib` which is not available in Lua 5.1. However, this is unrelated to the luv library as luvi itself should define the macro for Lua 5.1.
|
Any feedback on this? |
zhaozg
approved these changes
Nov 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposing the compat-5.3.h header file directly in the luv.h header file
is not a good idea, because it causes redefinition errors when building,
for example latest luvi version 2.8.0, with a shared luv library and
LuaJIT 2.0.5.
Therefore, include the compat header file in the luv.c source file.
Note, that luvi version 2.8.0 still fails to build against the shared luv
library using LuaJIT 2.0.5, as it does use
luaL_newlibwhich is notavailable in Lua 5.1. However, this is unrelated to the luv library as
luvi itself should define the macro for Lua 5.1.