Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: Fix absolute path detection on Windows #292

Merged
merged 1 commit into from
Jul 9, 2018

Conversation

squeek502
Copy link
Member

Fixes build error on Windows introduced in #291

See https://ci.appveyor.com/project/racker-buildbot/luvi/branch/master/job/lbnl00gj7bvjexqy

if(NOT file MATCHES "^/") will fail to detect absolute paths on Windows (which typically start with a drive letter like C:/, but can also have a network path like \\server\share).

Instead, get_filename_component with REALPATH or IS_ABSOLUTE should be used.

Fixes build error on Windows introduced in luvit#291
@rphillips rphillips merged commit ab872c1 into luvit:master Jul 9, 2018
@zhaozg
Copy link
Member

zhaozg commented Jul 10, 2018

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants