Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use lua-compat-5.3 for standard APIs #279

Merged
merged 1 commit into from
Mar 19, 2018
Merged

use lua-compat-5.3 for standard APIs #279

merged 1 commit into from
Mar 19, 2018

Conversation

zhaozg
Copy link
Member

@zhaozg zhaozg commented Mar 4, 2018 •
edited
Loading

The unified and compatible interface uses lua-compat-5.3 implementation to reduce conflicts when All In One build in luvi.

@creationix creationix merged commit 5e7c10a into luvit:master Mar 19, 2018
@creationix
Copy link
Member

I get more conflicts in luvi with this, even when I try the tiny build which shouldn't include openssl. Is there something I should update there?

@zhaozg
Copy link
Member Author

zhaozg commented Apr 24, 2018

ok, let me fix luvi, please wait PR.

@zhaozg
Copy link
Member Author

zhaozg commented Apr 24, 2018

hi @creationix Please apply #286, and update submodule luv int luvi, after apply luvit/luvi#169 will make that work sense.

@zhaozg
Copy link
Member Author

zhaozg commented Apr 24, 2018

And take the liberty to ask, may I join the luvit organization? @creationix

@creationix
Copy link
Member

Thanks!

@justinmk justinmk mentioned this pull request Nov 1, 2018
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhaozg @creationix