update luv to support latest libuv #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhaozg
force-pushed
the
master
branch
2 times, most recently
from
0bcf724
to
88a0db6
Compare
Closed
zhaozg
force-pushed
the
master
branch
12 times, most recently
from
6a78721
to
8e6d9bc
Compare
1. add LUV_UV_VERSION_GEQ macro to check libuv version when compile 2. add uv.signal_start_oneshot, uv.os_getenv, uv.os_setenv, uv.os_unsetenv, uv.os_gethostname, uv.translate_sys_error
|
oh nice, they added environment variable functions! |
|
It would be nice to get a version bump for luv. I can drop a separate environment management library from my project dependencies. |
|
Good point, I had forgot about this. I'm heading to Houston to help with volunteer flood cleanup this weekend so I'm not sure I'll get a build out. If I don't, feel free to ping me again next week. |
|
Oh wow, don't worry about this then. Good luck over there, I have friends and family down there too. Thanks for helping out! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.