-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot be built from release tarball with default make options #419
Comments
Building from source should work with a release tarball (not the Are you using |
Yes, I'm talking about the release tarball. I doesn't contain all submodules.
Haven't tried that yet. |
Whoops, you're right. That tarball really only exists for LuaRocks, which doesn't expect to need to compile Lua from source. For compiling everything from source, your best best would be to do a git clone. Is there a reason you want a tarball instead? |
Packaging. Using a git clone is suboptimal. The tarball should always have all submodules included. |
It's a bit harder of a call since this is a Lua module not tied to any specific Lua version. For packaging purposes, it should probably compile against whatever Lua version the user wants rather than compile LuaJIT from source, right? Could you describe your use case a bit more? Are there other similar Lua projects you're working with that handle this sort of thing better? |
I'm on a source distro. Either I compile against the system version (there is only one, which is Luajit-2.0.5) or I use the bundled one. I cannot use the bundled one, because it's not in the tarball. The user cannot choose any version.
This works |
I think this might just be down to default Maybe we should move to |
lua and luajit submodules are missing from the tarball: https://github.com/luvit/luv/tree/master/deps
Using system luajit doesn't work, because cmake checks are trying to access private headers, such as
lj_arch.h
. I have no idea why.The text was updated successfully, but these errors were encountered: