Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test fails when no dependecy to gson or jackson #61

Closed
emartynov opened this issue Apr 10, 2017 · 3 comments
Closed

Test fails when no dependecy to gson or jackson #61

emartynov opened this issue Apr 10, 2017 · 3 comments

Comments

@emartynov
Copy link

Hi guys,

Our tests are failing because we use Mochi as a json library (https://github.com/square/moshi). As for now we added Gson as test dependency but would be nice to have support for Moshi as well.

Kind Regards,
Eugen
@emartynov emartynov changed the title Test failing when no dependecy to gson or jackson Test fails when no dependecy to gson or jackson Apr 10, 2017
@lukas-krecan
Copy link
Owner

lukas-krecan commented Apr 10, 2017 •
edited
Loading

Hi, thanks for feedback. It should be possible, even though Moshi has some ugly "features" like this square/moshi#192. I already have a commit with the support 9926e3d Will think about it over night and maybe release tomorrow.

@emartynov
Copy link
Author

It is interesting. I made small comments for the commit.

@lukas-krecan
Copy link
Owner

Released as 1.22.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@emartynov @lukas-krecan